Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes #1201

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Miscellaneous fixes #1201

merged 5 commits into from
Oct 25, 2024

Conversation

aurianer
Copy link
Collaborator

I'm not sure I'll open my nvhpc PR since the amount of changes to make things work seems really important and I've still didn't manage yet. So in the meantime I transfer some of the commits which we might want to merge here.

@aurianer aurianer self-assigned this Oct 13, 2024
@aurianer
Copy link
Collaborator Author

cscs-ci run

Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think one of the unused variables should actually be used rather than removed.

miniapp/include/dlaf/miniapp/options.h Outdated Show resolved Hide resolved
@msimberg
Copy link
Collaborator

cscs-ci run

@msimberg
Copy link
Collaborator

HEMM timeout again... https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/4700071344751697/7514005670787789/-/jobs/8145589685#L2340. I've restarted the test.

@rasolca rasolca merged commit 86ac3ce into eth-cscs:master Oct 25, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants